Docs: Update Time Series examples (Clean Re-submission)#2272
Docs: Update Time Series examples (Clean Re-submission)#2272jaytiwarihub wants to merge 2 commits intokeras-team:masterfrom
Conversation
Summary of ChangesHello @jaytiwarihub, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating and improving the existing time series forecasting examples. The primary goal is to enhance the robustness of data loading and file path handling, ensuring better cross-platform compatibility and reliability. Additionally, metadata such as 'Last modified' dates have been refreshed, and the Jupyter notebooks have been regenerated to align with the updated scripts. This re-submission addresses and resolves prior merge conflicts. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates two time series examples, timeseries_weather_forecasting and timeseries_traffic_forecasting. The changes include updating the 'last modified' dates and, more importantly, improving the data loading logic to be more robust by using os.path.dirname and os.path.join for path manipulation. This is a good improvement over the previous brittle string manipulation. However, when regenerating the notebooks, local file paths were accidentally included in the notebook metadata. These should be removed to avoid exposing user-specific information.
| "colab": { | ||
| "collapsed_sections": [], | ||
| "name": "timeseries_traffic_forecasting", | ||
| "name": "C:\\Users\\om777\\keras-io\\examples\\timeseries\\timeseries_traffic_forecasting", |
There was a problem hiding this comment.
A hardcoded local file path has been committed to the notebook's metadata. This is likely unintentional and can expose private user information. It's best to revert this to a generic name for the notebook.
| "name": "C:\\Users\\om777\\keras-io\\examples\\timeseries\\timeseries_traffic_forecasting", | |
| "name": "timeseries_traffic_forecasting", |
| "colab": { | ||
| "collapsed_sections": [], | ||
| "name": "timeseries_weather_forecasting", | ||
| "name": "C:\\Users\\om777\\keras-io\\examples\\timeseries\\timeseries_weather_forecasting", |
There was a problem hiding this comment.
A hardcoded local file path has been committed to the notebook's metadata. This is likely unintentional and can expose private user information. It's best to revert this to a generic name for the notebook.
| "name": "C:\\Users\\om777\\keras-io\\examples\\timeseries\\timeseries_weather_forecasting", | |
| "name": "timeseries_weather_forecasting", |
|
Still your .ipynb files references your local path. You have to generate .ipynb and .md files from .py files. You can generate the example using the command for each .py files like this. Similarly follow for other example as well. |
|
@sachinprasadhs thanks , I'm on it plus other examples too |
|
This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you. |
2 participants
This PR updates the timeseries_weather_forecasting and timeseries_traffic_forecasting examples.
Changes:
Updated Last modified dates to the current date.
Regenerated .ipynb files to match the latest scripts.
Note: This is a clean re-submission of PR #2236 to resolve merge conflicts and history issues.